Fix Shortcut EventEmitter Leak/Re-render leaks #31779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintandrewhall
added
review
v7.0.0
performance
Team:Presentation
|
Pinging @elastic/kibana-canvas |
💚 Build Succeeded |
monfera
approved these changes
Feb 22, 2019
monfera
pushed a commit
to monfera/kibana
that referenced
this pull request
Feb 22, 2019
# Conflicts: # yarn.lock
monfera
pushed a commit
to monfera/kibana
that referenced
this pull request
Feb 22, 2019
# Conflicts: # yarn.lock
monfera
pushed a commit
to monfera/kibana
that referenced
this pull request
Feb 22, 2019
# Conflicts: # yarn.lock
monfera
pushed a commit
to monfera/kibana
that referenced
this pull request
Feb 22, 2019
# Conflicts: # yarn.lock
monfera
added a commit
that referenced
this pull request
Feb 22, 2019
monfera
added a commit
that referenced
this pull request
Feb 22, 2019
7 tasks
|
Thanks @monfera ... I had a nasty case of the flu Friday and lost track of this guy. You rock. |
clintandrewhall
added a commit
to clintandrewhall/kibana
that referenced
this pull request
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were seeing EventEmitter leaks involving
Shortcuts, and my analysis of unnecessary re-renders showedShortcutswas repainting excessively, (more than 300 times on Workpad load).I discovered this is due to the
Shortcutselement being rendered on every page of the workpad... I added a check to be sure the page was active, and that solved theventEmitterproblem.I then extracted out the logic into a standalone component and created bound functions in that component to prevent unnecessary repaint. Since the
selectedElementsandselectedElementIdsare being recreated with each aeroelastic change, I also added a fast-check of the props in the newWorkpadShortcutscomponent to prevent repaints.In all, this change fixes the steady increase in listeners being attached and GC'd, and drastically improves re-render on the main thread.
Listeners being created and GC'd, before, 365-391:
After, 16-130:
