[Infra UI] Change waffle map node to button for accessibility #31764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
review
[zube]: In Review
Feature:Metrics UI
|
Pinging @elastic/infrastructure-ui |
💚 Build Succeeded |
weltenwort
added
the
Team:Infra Monitoring UI - DEPRECATED
weltenwort
reviewed
Feb 25, 2019
| @@ -66,13 +66,13 @@ export class Node extends React.PureComponent<Props, State> { | |||
| <SquareOuter color={color}> | |||
| <SquareInner color={color}> | |||
| {valueMode ? ( | |||
| <ValueInner> | |||
| <ValueInner aria-label={`${node.name}, click to open menu`}> | |||
There was a problem hiding this comment.
Do we need to translate the aria labels?
| border: none; | ||
| &:focus { | ||
| outline: none !important; | ||
| border: 3px solid ${params => params.theme.eui.euiFocusRingColor}; |
There was a problem hiding this comment.
There is a euiFocusRingSize variable in the theme. Should we use it?
💚 Build Succeeded |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Feb 26, 2019
…c#31764) * Fixes elastic#28158 - Change waffle map node to button for accessibility * intl-izing the aria-labels; changing size to eui
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #28158 by changing the
ValueInnerdiv to a button for theNodecomponentChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately