Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Fix migrate assistant label and copy #31750

Merged
merged 3 commits into from
Feb 22, 2019

Conversation

formgeist
Copy link
Contributor

@formgeist formgeist commented Feb 21, 2019

Summary

A small oversight (probably on my part), but I've been calling it the Migration Assistant throughout, when it's actually called Upgrade assistant in Kibana. I'm rectifying my mistake to make it consistent with Kibana terminology. Otherwise it'd be rather confusing to users.

  • Updated help menu copy

screenshot 2019-02-21 at 22 38 58

  • Updated "No services" empty state copy on Services list
    image.png

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@formgeist formgeist added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support labels Feb 21, 2019
@formgeist formgeist requested a review from a team February 21, 2019 21:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@formgeist formgeist merged commit 1bfde5e into elastic:master Feb 22, 2019
@formgeist formgeist deleted the apm-fix-migrate-assistant-copy branch February 22, 2019 07:49
formgeist added a commit that referenced this pull request Feb 22, 2019
* Change link copy in help menu and services list empty state
formgeist added a commit that referenced this pull request Feb 22, 2019
* Change link copy in help menu and services list empty state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.0.0 v7.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants