Throw error when migration not defined in same plugin as mappings #31739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-operations |
This comment has been minimized.
This comment has been minimized.
spalger
reviewed
Feb 26, 2019
…ror-when-migration-in-wrong-plugin
This comment has been minimized.
This comment has been minimized.
…ror-when-migration-in-wrong-plugin
💚 Build Succeeded |
tylersmalley
approved these changes
Mar 4, 2019
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Mar 4, 2019
…astic#31739) * Throw error when migration not defined in same plugin as mappings * Apply PR feedback
|
@mikecote Please add some information about this change to the 7.2 breaking changes doc at https://www.elastic.co/guide/en/kibana/7.2/breaking-changes-7.2.html |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Jun 12, 2019
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Jun 12, 2019
mikecote
added a commit
that referenced
this pull request
Jun 12, 2019
mikecote
added a commit
that referenced
this pull request
Jun 12, 2019
mikecote
added
release_note:plugin_api_changes
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31694.
This PR makes the system throw an error when a plugin defines a migration but doesn't define/own the mappings. This is to enforce migrations to be defined in the same plugin that defines the mappings.
Dev Docs
Kibana will now throw an error on startup if a plugin has defined a saved object migration inside a plugin that doesn't define or own the mappings to.