[Maps] clear transient layer when required fields are cleared #31726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
v7.0.0
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
💚 Build Succeeded |
thomasneirynck
approved these changes
Feb 22, 2019
x-pack/plugins/maps/public/shared/layers/sources/es_geo_grid_source/es_geo_grid_source.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/shared/layers/sources/es_search_source/create_source_editor.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/shared/layers/sources/es_geo_grid_source/create_source_editor.js
Outdated
Show resolved
Hide resolved
| @@ -22,12 +22,17 @@ export class ESSearchSource extends AbstractESSource { | |||
| static description = 'Geospatial data from a Kibana index pattern'; | |||
|
|
|||
| static renderEditor({ onPreviewSource, inspectorAdapters }) { | |||
| const onSelect = (layerConfig) => { | |||
| const layerSource = new ESSearchSource({ | |||
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 22, 2019
…c#31726) * [Maps] clear transient layer when required fields are cleared * review feedback
This was referenced Feb 22, 2019
nreese
added a commit
that referenced
this pull request
Feb 22, 2019
#31776) * [Maps] clear transient layer when required fields are cleared * review feedback
nreese
added
non-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #31725
ES Documents and ES Grid aggregation source allow for clearing index pattern and geo field. This PR ensures the temp layer is removed if the user clears either index pattern or geo field so the
Add layerbutton is disabled in this statePrevents users from getting into the below state