[Maps] disable fit to data for geo_shape fields until elasticsearch supports a way to get the bounds #31638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upports a way to get the bounds
nreese
added
v7.0.0
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
thomasneirynck
approved these changes
Feb 21, 2019
| it('should register elasticsearch request in inspector', async () => { | ||
| const hits = await getHits(); | ||
| expect(hits).to.equal('6'); | ||
| it('should apply query to fit to bounds', async () => { |
There was a problem hiding this comment.
thanks for introducing this
| try { | ||
| const esResp = await searchSource.fetch(); | ||
| esBounds = _.get(esResp, 'aggregations.1.bounds'); | ||
| } catch(error) { |
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 21, 2019
…upports a way to get the bounds (elastic#31638) * [Maps] disable fit to data for geo_shape fields until elasticsearch supports a way to get the bounds * add function test for fit to bounds * add jest test for layer_toc_actions component * review feedback
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 21, 2019
…upports a way to get the bounds (elastic#31638) * [Maps] disable fit to data for geo_shape fields until elasticsearch supports a way to get the bounds * add function test for fit to bounds * add jest test for layer_toc_actions component * review feedback
|
@nreese when I add this index pattern - it doesn't show as one of the documents in elasticsearch documents layer in maps. Is that expected? |
|
What is the mapping for |
nreese
added
non-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #31589
get_boundsaggregation only supportgeo_point. There is no way to get the bounds for ageo_shapeso this PR just disables the option. The PR also properly handles anygeo_boundserrors.