[Maps] Remove unneeded and breaking layer condition that prevents cancel from add layer panel #31634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unless a layer's selected
kindsun
added
the
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
kindsun
changed the title
💚 Build Succeeded |
nreese
reviewed
Feb 21, 2019
There was a problem hiding this comment.
The check for this.state.layer around this.props.removeTransientLayer() can also be removed.
Lets add some functional tests to this PR for some of these flows. Lets add tests that verify
- Click
Add layer, verify add panel opens - Click
Cancel, verify add panel closes - Click
Add layer, add source. Save map. Verify transient layer is removed
nreese
reviewed
Feb 22, 2019
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
nreese
reviewed
Feb 23, 2019
| // Select layer | ||
| const vectorLayer = await PageObjects.maps.selectVectorLayer(); | ||
| // Confirm layer added | ||
| await PageObjects.common.sleep(1000); |
There was a problem hiding this comment.
sleeps lead to flaky tests because they are a work around for timing issues that can easily break.
Instead of sleep, verify Add layer button is active and spinner no longer exists. Do something like await addLayerButton.waitForDeletedByClassName('euiLoadingSpinner');
| panelOpen = await PageObjects.maps.isLayerAddPanelOpen(); | ||
| expect(panelOpen).to.be(false); | ||
| // Verify layer has been removed | ||
| await PageObjects.common.sleep(500); |
There was a problem hiding this comment.
Instead of sleep, wrap expect in retry. Sleeps lead to flaky tests because they mask timing issues
nreese
approved these changes
Feb 25, 2019
💚 Build Succeeded |
kindsun
added a commit
to kindsun/kibana
that referenced
this pull request
Feb 25, 2019
…cel from add layer panel (elastic#31634) * Remove unneeded and breaking layer condition that prevents cancelling unless a layer's selected * Add layer tests. Review feedback * .....and the test file * Review feedback. Factor out reusable maps test functions. Clean up * Picky picky * Review feedback. Remove sleeps # Conflicts: # x-pack/test/functional/apps/maps/index.js
kindsun
added a commit
to kindsun/kibana
that referenced
this pull request
Feb 25, 2019
…cel from add layer panel (elastic#31634) * Remove unneeded and breaking layer condition that prevents cancelling unless a layer's selected * Add layer tests. Review feedback * .....and the test file * Review feedback. Factor out reusable maps test functions. Clean up * Picky picky * Review feedback. Remove sleeps # Conflicts: # x-pack/plugins/maps/public/components/widget_overlay/layer_control/__snapshots__/view.test.js.snap # x-pack/plugins/maps/public/components/widget_overlay/layer_control/layer_toc/toc_entry/__snapshots__/view.test.js.snap # x-pack/plugins/maps/public/components/widget_overlay/layer_control/layer_toc/toc_entry/view.js # x-pack/plugins/maps/public/components/widget_overlay/layer_control/view.js # x-pack/test/functional/apps/maps/index.js
kindsun
added a commit
to kindsun/kibana
that referenced
this pull request
Feb 25, 2019
…cel from add layer panel (elastic#31634) * Remove unneeded and breaking layer condition that prevents cancelling unless a layer's selected * Add layer tests. Review feedback * .....and the test file * Review feedback. Factor out reusable maps test functions. Clean up * Picky picky * Review feedback. Remove sleeps # Conflicts: # x-pack/plugins/maps/public/components/widget_overlay/layer_control/__snapshots__/view.test.js.snap # x-pack/plugins/maps/public/components/widget_overlay/layer_control/layer_toc/toc_entry/__snapshots__/view.test.js.snap # x-pack/plugins/maps/public/components/widget_overlay/layer_control/layer_toc/toc_entry/view.js # x-pack/plugins/maps/public/components/widget_overlay/layer_control/view.js # x-pack/test/functional/apps/maps/index.js
kindsun
added a commit
that referenced
this pull request
Feb 25, 2019
…cel from add layer panel (#31634) (#31926) * Remove unneeded and breaking layer condition that prevents cancelling unless a layer's selected * Add layer tests. Review feedback * .....and the test file * Review feedback. Factor out reusable maps test functions. Clean up * Picky picky * Review feedback. Remove sleeps # Conflicts: # x-pack/test/functional/apps/maps/index.js
kindsun
added a commit
that referenced
this pull request
Feb 25, 2019
…cel from add layer panel (#31634) (#31932) * Remove unneeded and breaking layer condition that prevents cancelling unless a layer's selected * Add layer tests. Review feedback * .....and the test file * Review feedback. Factor out reusable maps test functions. Clean up * Picky picky * Review feedback. Remove sleeps # Conflicts: # x-pack/plugins/maps/public/components/widget_overlay/layer_control/__snapshots__/view.test.js.snap # x-pack/plugins/maps/public/components/widget_overlay/layer_control/layer_toc/toc_entry/__snapshots__/view.test.js.snap # x-pack/plugins/maps/public/components/widget_overlay/layer_control/layer_toc/toc_entry/view.js # x-pack/plugins/maps/public/components/widget_overlay/layer_control/view.js # x-pack/test/functional/apps/maps/index.js
kindsun
added a commit
that referenced
this pull request
Feb 25, 2019
…ts cancel from add layer panel (#31634) (#31930) * [Maps] Remove unneeded and breaking layer condition that prevents cancel from add layer panel (#31634) * Remove unneeded and breaking layer condition that prevents cancelling unless a layer's selected * Add layer tests. Review feedback * .....and the test file * Review feedback. Factor out reusable maps test functions. Clean up * Picky picky * Review feedback. Remove sleeps # Conflicts: # x-pack/plugins/maps/public/components/widget_overlay/layer_control/__snapshots__/view.test.js.snap # x-pack/plugins/maps/public/components/widget_overlay/layer_control/layer_toc/toc_entry/__snapshots__/view.test.js.snap # x-pack/plugins/maps/public/components/widget_overlay/layer_control/layer_toc/toc_entry/view.js # x-pack/plugins/maps/public/components/widget_overlay/layer_control/view.js # x-pack/test/functional/apps/maps/index.js * Remove trailing space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bool condition appears to be no longer necessary and in fact, causes a bug. Requiring a layer to have been selected prevents cancelling before a layer has been selected. This update removes this condition.