Fixing the test subject for the create dashboard button #31624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
lizozom
approved these changes
Feb 25, 2019
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Feb 25, 2019
kobelb
added a commit
that referenced
this pull request
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes that #30610 introduced, we removed the
newDashboardLinktest subject, and replaced it with thenewItemButton, however, we didn't update the dashboard mode tests. The tests are passing only because we're ensuring the button doesn't exist, and it won't ever exist.