Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refreshConfig to embeddable container state #31611

Merged
merged 2 commits into from
Feb 25, 2019

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Feb 20, 2019

This PR adds refreshConfig to embeddable containerState so that refreshConfig gets passed down to the embeddable. The maps application is working on an map embeddable and will need the refreshConfig to handle auto-refreshing.

@nreese nreese mentioned this pull request Feb 20, 2019
8 tasks
@nreese nreese added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.2.0 labels Feb 20, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@nreese nreese requested review from lizozom and lukasolson February 20, 2019 20:31
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not totally related to this PR, but to me it seems odd there's an update on every keypress of the refresh config while the time settings require you to click the update button.

In any case, this PR LGTM!

@nreese nreese merged commit 9147715 into elastic:master Feb 25, 2019
nreese added a commit to nreese/kibana that referenced this pull request Feb 25, 2019
* Add refreshConfig to embeddable container state

* TS fun
nreese added a commit that referenced this pull request Feb 25, 2019
* Add refreshConfig to embeddable container state

* TS fun
@timroes timroes added the release_note:skip Skip the PR/issue when compiling release notes label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants