Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Switch uptime localization from i18n provider to context #31601

Merged
merged 1 commit into from
Feb 26, 2019
Merged

[Uptime] Switch uptime localization from i18n provider to context #31601

merged 1 commit into from
Feb 26, 2019

Conversation

justinkambic
Copy link
Contributor

Summary

We switched from i18nContext to i18nProvider previously. We should have continued using the context instead. This PR will correct this error.

Testing this PR

  • Load the Uptime application
  • Ensure that text is displayed as expected

@justinkambic justinkambic added v7.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v6.7.0 labels Feb 20, 2019
@justinkambic justinkambic self-assigned this Feb 20, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

azasypkin
azasypkin approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinkambic justinkambic merged commit c067a77 into elastic:master Feb 26, 2019
justinkambic added a commit to justinkambic/kibana that referenced this pull request Feb 26, 2019
@justinkambic
Switch uptime internationalization from i18n provider to context. (el…
1ea9da9 
…astic#31601)
@justinkambic justinkambic mentioned this pull request Feb 26, 2019
Merged
7 tasks
justinkambic added a commit to justinkambic/kibana that referenced this pull request Feb 26, 2019
@justinkambic
Switch uptime internationalization from i18n provider to context. (el…
31c4e46 
…astic#31601)
This was referenced Feb 26, 2019
Closed
Merged
justinkambic added a commit that referenced this pull request Feb 27, 2019
@justinkambic
Switch uptime internationalization from i18n provider to context. (#3…
38d1cf3 
…1601) (#32064)
justinkambic added a commit that referenced this pull request Feb 27, 2019
@justinkambic
Switch uptime internationalization from i18n provider to context. (#3…
5dd8f8d 
…1601) (#32066)
@justinkambic
Copy link
Contributor Author

Backported to:

@justinkambic justinkambic deleted the uptime_re-add-i18ncontext branch February 27, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

Assignees

@justinkambic justinkambic

Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinkambic @elasticmachine @azasypkin