Add some types for interpter plugin registration #31600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
stacey-gammon
force-pushed
the
2019-02-20-legacy-server-type
branch
from
643c81b to
958530d
Compare
💔 Build Failed |
stacey-gammon
force-pushed
the
2019-02-20-legacy-server-type
branch
from
958530d to
d757b85
Compare
💔 Build Failed |
joshdover
reviewed
Feb 22, 2019
sorenlouv
reviewed
Feb 22, 2019
| @@ -30,7 +30,8 @@ describe('timeseriesFetcher', () => { | |||
| end: 1528977600000, | |||
| client: clientSpy, | |||
| config: { | |||
| get: () => 'myIndex' as any | |||
| get: () => 'myIndex' as any, | |||
| has: () => true | |||
There was a problem hiding this comment.
@stacey-gammon Do we need to mock this property if we never call it?
There was a problem hiding this comment.
It appears so @sqren:
unless I am missing something, I believe since the function expects the Config object, even if it's not used internally, because it's required on the config object, it has to exist.
💔 Build Failed |
sorenlouv
approved these changes
Feb 27, 2019
stacey-gammon
force-pushed
the
2019-02-20-legacy-server-type
branch
from
1df28bf to
8f95cd1
Compare
💔 Build Failed |
|
Failed on what looks like a ci issue: jenkins, test this |
💔 Build Failed |
stacey-gammon
added
the
Team:Core
|
Pinging @elastic/kibana-platform |
💚 Build Succeeded |
stacey-gammon
force-pushed
the
2019-02-20-legacy-server-type
branch
from
f4772d3 to
9b5ef32
Compare
|
@joshdover - any more comments or is this good to merge? |
💔 Build Failed |
lukeelmers
reviewed
Mar 4, 2019
kibana.d.ts
Outdated
| export type InitPluginFunction = (server: Server) => void; | ||
| export interface UiExports { | ||
| injectDefaultVars: (server: Server) => { [key: string]: any }; | ||
| } |
There was a problem hiding this comment.
Can InitPluginFunction and UiExports be re-exported from LegacyKibanaPluginSpec, since they're already included once there?
There was a problem hiding this comment.
yes that makes much more sense.
💚 Build Succeeded |
lukeelmers
approved these changes
Mar 5, 2019
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Mar 5, 2019
* Some basic types for top level legacy plugin registration * put typescript interface closer to implementation * Use default export, you have to * fix build and address code review comments
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Mar 6, 2019
* Some basic types for top level legacy plugin registration * put typescript interface closer to implementation * Use default export, you have to * fix build and address code review comments
stacey-gammon
added a commit
that referenced
this pull request
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some typings for top level legacy plugin registration, and use-age in interpreter plugin.