Fix i18n usage in flyout_session #31577
Conversation
💔 Build Failed |
|
Test failures seems legit, I guess you just need smth like |
CONTRIBUTING.md
Outdated
| @@ -21,6 +21,7 @@ A high level overview of our contributing guidelines. | |||
| - [Customizing `config/kibana.dev.yml`](#customizing-configkibanadevyml) | |||
| - [Setting Up SSL](#setting-up-ssl) | |||
| - [Linting](#linting) | |||
| - [I18N](#i18n) | |||
There was a problem hiding this comment.
nit: let's make it a bit more obvious with something like Internationalization (i18n)?
There was a problem hiding this comment.
Makes sense - I just went with Internationalization (more consistent with other headings)
CONTRIBUTING.md
Outdated
| @@ -278,6 +279,22 @@ IntelliJ | Settings » Languages & Frameworks » JavaScript » Code Quality To | |||
|
|
|||
| Another tool we use for enforcing consistent coding style is EditorConfig, which can be set up by installing a plugin in your editor that dynamically updates its configuration. Take a look at the [EditorConfig](http://editorconfig.org/#download) site to find a plugin for your editor, and browse our [`.editorconfig`](https://github.com/elastic/kibana/blob/master/.editorconfig) file to see what config rules we set up. | |||
|
|
|||
| ### I18N | |||
|
|
|||
| All labels and info texts in Kibana go through an i18n-function to add translation capabilities. Please take a look at the [readme](packages/kbn-i18n/README.md) and the [guideline](packages/kbn-i18n/GUIDELINE.md) of the i18n package on how to do so. | |||
There was a problem hiding this comment.
nit: All user-facing labels .....
nit: i18n-function sounds a bit confusing... Maybe something shorter and more pushy like All user-facing labels and info texts in Kibana should be internationalized. or something along these lines?
There was a problem hiding this comment.
Way better, thanks for the suggestion.
💚 Build Succeeded |
Switches to I18nContext instead of I18nProvider and documents this.