[test/telemetry] relax stats assertion #31536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
added
review
Team:Core
|
retest |
💚 Build Succeeded |
|
Pinging @elastic/stack-monitoring |
|
If anyone gets time, I know platform owns telemetry but the code is sorta shared. Sorry for all the pings |
tylersmalley
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this test does an exact match on expected metrics. These metrics depend on data from external services and change independent of Kibana. Instead of allowing for an exact match we test that the current list is a subset of the expected list. We can relax it further if it becomes an issue, but we haven't had any tests fail in the opposite direction yet so I think its a modest start.