-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve x-axis order in vislib. #31533
Conversation
This comment has been minimized.
This comment has been minimized.
bd04fd9
to
0b24b31
Compare
This comment has been minimized.
This comment has been minimized.
Pinging @elastic/kibana-app |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ad98cc4
to
33fb75a
Compare
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works on chrome linux
i have some minor comments/questions around code
src/legacy/ui/public/agg_response/point_series/_fake_x_aspect.js
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, tested locally together with Peter and fix the ordering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #31534.
Summary
This resolves an issue where the original x values sort order sent back
by ES was lost for point series / vislib visualizations. This
was due to the way the point series agg response handler generated
series data, only filling in series values as it encountered them
bucket-by-bucket, rather than first looking at all x-values and ordering
them consistently within each series.
With this change, the ordered x values are preserved and stored with the
chart, so they can be accessed later in
vislib/components/zero_injection
.QA
kibana_sample_data_logs
today
extension.keyword
, order: alphabetical ascending, size: 5machine.os.keyword
, order: count descending, size: 3master
).Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibility