Fix Visual Builder wrong color rules on multiple metric #31455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
flash1293
approved these changes
Feb 19, 2019
timroes
added
Feature:TSVB
|
Pinging @elastic/kibana-app |
alexwizp
approved these changes
Feb 21, 2019
| @@ -34,7 +34,8 @@ function getColors(props) { | |||
| if (model.background_color_rules) { | |||
| model.background_color_rules.forEach((rule) => { | |||
| if (rule.operator && rule.value != null) { | |||
| const value = series[0] && getLastValue(series[0].data) || 0; | |||
| const value = (series[0] && getLastValue(series[0].data)) || | |||
There was a problem hiding this comment.
What about to simplify it
const value = getLastValue((series[0] || series[1] || {}).data || 0);
But it's optional
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Feb 21, 2019
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Feb 21, 2019
sulemanof
added a commit
that referenced
this pull request
Feb 21, 2019
sulemanof
added a commit
that referenced
this pull request
Feb 21, 2019
This was referenced Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16431 .
The same problem has been already fixed for
gaugetab in PR: #27810 - find out the full description of a problem there.