Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navbar icons missing directives #31450

Merged
merged 2 commits into from
Mar 4, 2019

Conversation

mistic
Copy link
Member

@mistic mistic commented Feb 19, 2019

This is an improved solution for the issue #29097 and also a solution for #31085.

@mistic mistic added review Team:Operations Team label for Operations Team v8.0.0 v7.2.0 labels Feb 19, 2019
@mistic mistic self-assigned this Feb 19, 2019
@mistic mistic requested a review from spalger February 19, 2019 03:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@mistic mistic merged commit 27d91de into elastic:master Mar 4, 2019
mistic added a commit to mistic/kibana that referenced this pull request Mar 4, 2019
* fix(NA): missing import on chrome for react components directives.

* refact(NA): remove the need for loading all ui modules on the status page.
@mistic
Copy link
Member Author

mistic commented Mar 4, 2019

7.x: a2eab3e
6.7: cc8a0f3
6.6: a226c86

mistic added a commit that referenced this pull request Mar 4, 2019
* fix(NA): missing import on chrome for react components directives.

* refact(NA): remove the need for loading all ui modules on the status page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants