Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[monitoring] only start bulk uploader once #31307

Merged
merged 2 commits into from
Feb 21, 2019
Merged

[monitoring] only start bulk uploader once #31307

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e6ef5f
[monitoring] only start bulk uploader once
jbudz Feb 15, 2019
9272124
Merge branch 'master' into monitoring/start_once
jbudz Feb 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion x-pack/plugins/monitoring/server/kibana_monitoring/bulk_uploader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,13 @@ export class BulkUploader {

// this is internal bulk upload, so filter out API-only collectors
const filterThem = _collectorSet => _collectorSet.getFilteredCollectorSet(c => c.ignoreForInternalUploader !== true);
this._fetchAndUpload(filterThem(collectorSet)); // initial fetch

if (this._timer) {
clearInterval(this._timer);
} else {
this._fetchAndUpload(filterThem(collectorSet)); // initial fetch
}

this._timer = setInterval(() => {
this._fetchAndUpload(filterThem(collectorSet));
}, this._interval);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll likely want to wait for completion of _fetchAndUpload before restarting the interval. this may make many requests, and could result in a fair amount of back pressure

Copy link
Member

@azasypkin azasypkin Feb 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and Cloud already suffered from this once: #30058

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 opened #31498. quick fix for patching and we can address that separately.

Expand Down