Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of 's' regex flag in KQL #31292

Merged
merged 2 commits into from
Feb 19, 2019
Merged

Remove use of 's' regex flag in KQL #31292

merged 2 commits into from
Feb 19, 2019

Conversation

lukasolson
Copy link
Member

Fixes #31288.

#30850 added support for querying field names with newlines, but it did so by using a regex flag that is supported in Chrome but not yet in Firefox or IE.

This PR uses a different approach to accomplish the same behavior without using this flag.

@lukasolson lukasolson self-assigned this Feb 15, 2019
@lukasolson lukasolson requested a review from flash1293 February 15, 2019 17:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@lukasolson lukasolson requested review from Bargs and removed request for flash1293 February 15, 2019 17:51
Bargs
Bargs approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@Bargs Bargs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test locally, but the code LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lukasolson
Copy link
Member Author

Retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@spalger
Copy link
Contributor

spalger commented Feb 16, 2019

Merged master to get the tests passing

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lukasolson lukasolson merged commit 41edbe4 into elastic:master Feb 19, 2019
lukasolson added a commit that referenced this pull request Feb 19, 2019
@lukasolson
Remove use of 's' regex flag (#31292)
ef3fd80
lukasolson added a commit that referenced this pull request Feb 19, 2019
@lukasolson
Remove use of 's' regex flag (#31292)
b2e35ab
lukasolson added a commit that referenced this pull request Feb 19, 2019
@lukasolson
Remove use of 's' regex flag (#31292)
7832c7c
lukasolson added a commit that referenced this pull request Feb 19, 2019
@lukasolson
Remove use of 's' regex flag (#31292)
65991cd
@lukasolson
Copy link
Member Author

lukasolson commented Feb 19, 2019 •
edited by Bargs
Loading

7.x (7.1.0): ef3fd80
7.0 (7.0.0): b2e35ab
6.7 (6.7.0): 7832c7c
6.6 (6.6.2): 65991cd

@Bargs Bargs added v6.6.2 and removed v6.6.1 labels Feb 25, 2019
@lukasolson lukasolson deleted the fixKqlWildcardRegex branch December 2, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bargs Bargs Bargs approved these changes

Assignees

@lukasolson lukasolson

Labels
Feature:KQL KQL review Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.6.2 v6.7.0 v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukasolson @elasticmachine @spalger @Bargs