-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telemetry] collect xpack.cloud details #31180
Conversation
I think the cloud id includes the uuid in plaintext. If so, that's probably the value we'd want to send rather than the whole cloud id. The term Someone from the cloud team might be able to clarify here, and you can see cloud ids in action via the beats modules getting started instructions from the Kibana home page of a cluster deployed in Elastic Cloud. |
Pinging @elastic/kibana-platform |
This comment has been minimized.
This comment has been minimized.
@epixa i added the |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
const { id } = server.config().get(`xpack.cloud`); | ||
|
||
return { | ||
isCloudEnabled: !!id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to not check that the type is a string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both should work for our case.
Checking for 'falesy' ids might protect us from unpredicted scenarios (empty string ids etc). More importantly; Checks for isCloudEnabled
in other places in our code use !!id
so this also ensures consistency (I'd favor consistency personally).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ for consistency
* collect xpack.cloud details * add elasticsearch cluster uuid * remove cloud ID from telemetry stats * remove esUUID from telemtry stats
* collect xpack.cloud details * add elasticsearch cluster uuid * remove cloud ID from telemetry stats * remove esUUID from telemtry stats
* collect xpack.cloud details * add elasticsearch cluster uuid * remove cloud ID from telemetry stats * remove esUUID from telemtry stats
* [Telemetry] collect xpack.cloud details (#31180) * collect xpack.cloud details * add elasticsearch cluster uuid * remove cloud ID from telemetry stats * remove esUUID from telemtry stats * add stack_stats.kibana.plugins.cloud.isCloudEnabled
Removal of found plugin in cloud will break the ability in telemetry to determine if the metrics are coming from Cloud or not.
This Change adds the following to the telemetry metric under plugins:
if cloud is not enabled, the telemetry will report
isCloudEnabled: false
. I favored this over not reporting at all when cloud is not enabled with the motivation to keep the telemetry object consistent in all cases.