Add referenced pipeline aggs to every level of query #31121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:Data Table
|
Pinging @elastic/kibana-app |
flash1293
changed the title
|
Would it make sense to add a functional test for this? |
💚 Build Succeeded |
|
unit test is perfect imo |
lukeelmers
approved these changes
Feb 21, 2019
| vis.isHierarchical = _.constant(true); | ||
|
|
||
| const topLevelDsl = vis.aggs.toDsl(vis.isHierarchical())['2']; | ||
| expect(topLevelDsl.aggs).to.have.keys(['1', '1-bucket']); |
There was a problem hiding this comment.
nit: It might be nice to include an assertion for the correct buckets_path as well; something like:
expect(topLevelDsl.aggs['1'].avg_bucket).to.have.property('buckets_path', '1-bucket>_count');I realize that isn't validating the precise problem you are fixing here, but for those looking at this test in the future, it could make it clearer how everything fits together & why we need to check that the parent aggs have been added at each level.
| @@ -193,6 +193,13 @@ class AggConfigs extends IndexedArray { | |||
| if (subAggs && nestedMetrics) { | |||
| nestedMetrics.forEach(agg => { | |||
| subAggs[agg.config.id] = agg.dsl; | |||
| // if a nested metric agg has parent aggs, we have to add them to every level of the tree | |||
| // to make sure "bucket_path" references in the nested metric agg itself are still working | |||
There was a problem hiding this comment.
++ This comment is super helpful, thanks for adding.
💔 Build Failed |
flash1293
force-pushed
the
25974/data-table-bucket-metrics
branch
from
09a2a82 to
fae9520
Compare
💚 Build Succeeded |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 21, 2019
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 21, 2019
This was referenced Feb 21, 2019
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 21, 2019
flash1293
added a commit
that referenced
this pull request
Feb 22, 2019
flash1293
added a commit
that referenced
this pull request
Feb 22, 2019
flash1293
added a commit
that referenced
this pull request
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #25974
When using sibling pipeline aggregations as metric and activating "Show metric at all levels", the resulting ES query didn't correctly add the referenced pipeline aggs to every level.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers