Using content-disposition pkg for non-US font titles in reporting
#30895
Conversation
tsullivan
added
v7.0.0
(Deprecated) Feature:Reporting
💔 Build Failed |
|
Failures look legitimate |
💔 Build Failed |
|
Retest |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
💔 Build Failed |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
|
:dank: |
| @@ -287,6 +286,7 @@ | |||
| "@types/joi": "^13.4.2", | |||
| "@types/jquery": "^3.3.6", | |||
| "@types/js-yaml": "^3.11.1", | |||
| "@types/json5": "^0.0.30", | |||
There was a problem hiding this comment.
Unrelated change automatically done by yarn?
There was a problem hiding this comment.
Yup, likely just wasn't properly alphabetized before?
There was a problem hiding this comment.
might as well leave it in, it'll just end up as an unrelated change in some other PR :D
x-pack/plugins/reporting/server/routes/lib/get_document_payload.ts
Outdated
Show resolved
Hide resolved
| }; | ||
| } | ||
|
|
||
| return function getDocumentPayload(doc) { | ||
| const { status, output, jobtype: jobType, payload: { title } = {} } = doc._source; | ||
| return function getDocumentPayload(doc: any) { |
There was a problem hiding this comment.
After #31188 goes in, we can replace the any with a type :D
💚 Build Succeeded |
|
The code change looks great, but can you add some steps for a quick manual verification? |
|
@tsullivan to repro (on master) do:
|
|
Will work on backporting this into 6.7 and 7.0 |
|
Has this not been backported to |
|
Correct me if I'm wrong, but it looks like this was first available in 7.3, not 7.0 or 7.2 as labeled here previously. |
Uses the
content-dispositionpkg found by @spalger to properly handle filename's with non-ASCII characters. Also did a quick TS-ify of the problematic module.