Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove type filter helper #30887

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Remove type filter helper #30887

merged 2 commits into from
Feb 13, 2019

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Feb 12, 2019 •
edited
Loading

This is no longer required in ES 7.0 onwards and will remove warnings from the ES deprecation log of this nature:

[types removal] Using the _type field in queries and aggregations is deprecated, prefer to use a field instead.

@ycombinator
Remove type filter helper.
78c82f9 
This is no longer required in ES 7.0 onwards.
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring

@elasticmachine
Copy link
Contributor

💔 Build Failed

chrisronline
chrisronline approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM. If/When CI goes green, this is good to go

@elasticmachine
Copy link
Contributor

💔 Build Failed

@chrisronline
Copy link
Contributor

I ran the following tests locally and they all passed:

  • Mocha -> yarn test:mocha
  • API tests -> node scripts/functional_test_server.js -> node ../scripts/functional_test_runner.js --grep "Monitoring" --config test/api_integration/config.js
  • Functional tests -> node scripts/functional_test_server.js -> node ../scripts/functional_test_runner.js --grep "Monitoring" --config test/functional/config.js

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@ycombinator ycombinator merged commit 3469347 into elastic:master Feb 13, 2019
@ycombinator ycombinator mentioned this pull request Feb 13, 2019
Merged
ycombinator added a commit to ycombinator/kibana that referenced this pull request Feb 13, 2019
@ycombinator
Remove type filter helper (elastic#30887)
a690b4d 
* Remove type filter helper.

This is no longer required in ES 7.0 onwards.

* Remove more usages of filter helper
@ycombinator ycombinator mentioned this pull request Feb 13, 2019
Merged
ycombinator added a commit to ycombinator/kibana that referenced this pull request Feb 13, 2019
@ycombinator
Remove type filter helper (elastic#30887)
ed31b28 
* Remove type filter helper.

This is no longer required in ES 7.0 onwards.

* Remove more usages of filter helper
ycombinator added a commit that referenced this pull request Feb 13, 2019
@ycombinator
[7.x] Remove type filter helper (#30887) (#30907)
52b6ea7 
Backports the following commits to 7.x:
 - Remove type filter helper  (#30887)
ycombinator added a commit that referenced this pull request Feb 13, 2019
@ycombinator
Remove type filter helper (#30887) (#30908)
ae7d3e4 
* Remove type filter helper.

This is no longer required in ES 7.0 onwards.

* Remove more usages of filter helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisronline chrisronline chrisronline approved these changes

Assignees
No one assigned
Labels
backport pending review Team:Monitoring Stack Monitoring team v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ycombinator @elasticmachine @chrisronline