-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] K7 design related fixes #30833
Conversation
💚 Build Succeeded |
@ryankeairns is this good for review or were you making anymore changes? |
@alexfrancoeur it is ready for review. Note on font sizes: I set the menu bar (above the workpad), toolbar (below the workpad), and tabs in the sidebar all to 14px (smaller). Beyond that, I'd like to do a broader comparison across K7 as things settle down before making blanket typography changes to other labels, titles, etc. For example, there is work ongoing in the new Viz builder and in Maps, both of which also have sidebars, so it would be good to compare and work towards consistency. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a code review only. LGTM.
@ryankeairns Can you do one more thing that's been bugging me? Can you remove the |
Pinging @elastic/kibana-canvas |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes! A small commit with the top/left unification would be neat before the merge
💚 Build Succeeded |
* K7 design related fixes * remove compressed from table for consistency * remove fullscreen styles related to K6 nav elements
* K7 design related fixes * remove compressed from table for consistency * remove fullscreen styles related to K6 nav elements
Fixes #30711 #30333 #30735
Summary
Fixes a few design related issues in the K7 theme:
Screenshots
Fullscreen has black background to left edge
Canvas chrome font size is 14px
Loading screen has lighter font color in dark mode
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)For maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately