Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] K7 design related fixes #30833

Merged
merged 3 commits into from
Feb 13, 2019

Conversation

ryankeairns
Copy link
Contributor

Fixes #30711 #30333 #30735

Summary

Fixes a few design related issues in the K7 theme:

  • removes white space (on left hand side) in fullscreen mode
  • reduces the font size within Canvas chrome areas (i.e. header and footer buttons, sidebar tabs)
  • makes 'Canvas is loading' text lighter on loading screen

Screenshots

Fullscreen has black background to left edge
screenshot 2019-02-12 07 42 24

Canvas chrome font size is 14px
screenshot 2019-02-12 08 31 12

screenshot 2019-02-12 08 31 32

Loading screen has lighter font color in dark mode
screenshot 2019-02-12 08 13 06

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexfrancoeur
Copy link

@ryankeairns is this good for review or were you making anymore changes?

@ryankeairns
Copy link
Contributor Author

@alexfrancoeur it is ready for review.

Note on font sizes: I set the menu bar (above the workpad), toolbar (below the workpad), and tabs in the sidebar all to 14px (smaller). Beyond that, I'd like to do a broader comparison across K7 as things settle down before making blanket typography changes to other labels, titles, etc.

For example, there is work ongoing in the new Viz builder and in Maps, both of which also have sidebars, so it would be good to compare and work towards consistency.

Thanks!

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a code review only. LGTM.

@cchaos
Copy link
Contributor

cchaos commented Feb 12, 2019

@ryankeairns Can you do one more thing that's been bugging me? Can you remove the compressed prop from the canvas workpad listing table? The text is sooo tiny but it's the primary list. And just looks so small now against the table controls.

@ryankeairns ryankeairns changed the title K7 design related fixes [Canvas] K7 design related fixes Feb 12, 2019
@ryankeairns ryankeairns added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Feb 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@monfera monfera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! A small commit with the top/left unification would be neat before the merge

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@ryankeairns ryankeairns merged commit 8c8a4a2 into elastic:master Feb 13, 2019
ryankeairns pushed a commit to ryankeairns/kibana that referenced this pull request Feb 13, 2019
* K7 design related fixes

* remove compressed from table for consistency

* remove fullscreen styles related to K6 nav elements
ryankeairns pushed a commit to ryankeairns/kibana that referenced this pull request Feb 13, 2019
* K7 design related fixes

* remove compressed from table for consistency

* remove fullscreen styles related to K6 nav elements
ryankeairns pushed a commit that referenced this pull request Feb 13, 2019
* K7 design related fixes

* remove compressed from table for consistency

* remove fullscreen styles related to K6 nav elements
ryankeairns pushed a commit that referenced this pull request Feb 13, 2019
* K7 design related fixes

* remove compressed from table for consistency

* remove fullscreen styles related to K6 nav elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.0.0 v7.0.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants