Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates load object text now that we do not load visualizations #30829

Merged

Conversation

jasonrhodes
Copy link
Member

Closes #29245

Summary

Removes message about loading dashboards and visualizations now that we no longer load those from the set up instructions page.

Note: "Load Kibana Objects" is the title here and cannot be changed.

Before:
screen shot 2019-02-12 at 9 03 27 am

Now:
screen shot 2019-02-12 at 9 08 12 am

@jasonrhodes jasonrhodes requested a review from a team February 12, 2019 15:16
@elasticmachine
Copy link
Contributor

💔 Build Failed

@jasonrhodes
Copy link
Member Author

retest

defaultMessage:
'Load index pattern, visualizations, and pre-defined dashboards. \
An index pattern is required for some features in the APM UI.',
defaultMessage: 'An APM index pattern is required for some features in the APM UI.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be helpful to list some affected features?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep this as close to what was recommended in the ticket as possible for now.

@jasonrhodes
Copy link
Member Author

retest

2 similar comments
@jasonrhodes
Copy link
Member Author

retest

@jasonrhodes
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants