Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BeatsCM] remove type from ES template and requests (#30549) #30823

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

mattapperson
Copy link
Contributor

This PR re-applies
#30549, reverted in
#30728, due to the bug in the ES plugin that is now fixed and bam-ported via
#30733

* remove dype from ES template and requests

* remove doc type?
@elasticmachine
Copy link
Contributor

Pinging @elastic/beats

@elasticmachine

This comment has been minimized.

@ph ph added the blocker label Feb 13, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@Crazybus
Copy link

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattapperson mattapperson merged commit f280ea0 into elastic:master Feb 14, 2019
mattapperson added a commit to mattapperson/kibana that referenced this pull request Feb 14, 2019
…lastic#30823)

* remove dype from ES template and requests

* remove doc type?
mattapperson added a commit to mattapperson/kibana that referenced this pull request Feb 14, 2019
…lastic#30823)

* remove dype from ES template and requests

* remove doc type?
mattapperson added a commit to mattapperson/kibana that referenced this pull request Feb 14, 2019
…lastic#30823)

* remove dype from ES template and requests

* remove doc type?
mattapperson added a commit to mattapperson/kibana that referenced this pull request Feb 14, 2019
…lastic#30823)

* remove dype from ES template and requests

* remove doc type?
mattapperson added a commit that referenced this pull request Feb 14, 2019
…#31115)

* remove dype from ES template and requests

* remove doc type?
mattapperson added a commit that referenced this pull request Feb 14, 2019
…#31116)

* remove dype from ES template and requests

* remove doc type?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants