Fix: Switch sample web logs fonts to 48px #30747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they still look good and fit in their containers better
w33ble
added
review
v7.0.0
Team:Presentation
|
Pinging @elastic/kibana-canvas |
cqliu1
approved these changes
Feb 11, 2019
w33ble
added a commit
that referenced
this pull request
Feb 12, 2019
they still look good and fit in their containers better
w33ble
added a commit
that referenced
this pull request
Feb 12, 2019
they still look good and fit in their containers better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29893
Changes the metric text font size from 60px (
size=60) to 48px (size=48). They still look good and fit in their containers now. Label text is unchanged.This won't fix existing sample workpads, there's nothing we can do there, but at least newly added sample workpads will work now. Deleting and re-adding the sample web logs will also fix things, since it'll delete and re-create the workpad with the new font size.
Before
Note how the bytes transferred text is clipped
After
No more clipping