-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs UI] Fix row height glitch on mouse over #30744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
review
v7.0.0
[zube]: In Review
Feature:Logs UI
Logs UI feature
v6.7.0
labels
Feb 11, 2019
Pinging @elastic/infrastructure-ui |
weltenwort
approved these changes
Feb 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems to do it 👍
retest |
💚 Build Succeeded |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Feb 12, 2019
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Feb 12, 2019
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Feb 12, 2019
simianhacker
added a commit
that referenced
this pull request
Feb 13, 2019
simianhacker
added a commit
that referenced
this pull request
Feb 13, 2019
simianhacker
added a commit
that referenced
this pull request
Feb 13, 2019
@simianhacker this seems to still happen in |
Looks like the empty lines are narrower than normal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #30185 by changing the
font-size
to0.9em
. I originally tried to change theiconSize
per EUI documentation but it didn't seem to have any effect.