Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Fix row height glitch on mouse over #30744

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Feb 11, 2019

This PR fixes #30185 by changing the font-size to 0.9em. I originally tried to change the iconSize per EUI documentation but it didn't seem to have any effect.

icon-size-demo

@elasticmachine
Copy link
Contributor

Pinging @elastic/infrastructure-ui

@weltenwort weltenwort self-assigned this Feb 12, 2019
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems to do it 👍

@simianhacker
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@simianhacker simianhacker merged commit 7756ba0 into elastic:master Feb 12, 2019
simianhacker added a commit to simianhacker/kibana that referenced this pull request Feb 12, 2019
simianhacker added a commit to simianhacker/kibana that referenced this pull request Feb 12, 2019
simianhacker added a commit to simianhacker/kibana that referenced this pull request Feb 12, 2019
@makwarth
Copy link

@simianhacker this seems to still happen in master for some log lines:

kapture 2019-02-19 at 10 46 46

@weltenwort
Copy link
Member

Looks like the empty lines are narrower than normal.

@simianhacker simianhacker deleted the fix-30185 branch April 17, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs UI] Row height hover glitch
5 participants