Expand add panels flyout and increase default rows per page #30508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: flash1293 <[email protected]>
|
Pinging @elastic/kibana-app |
💔 Build Failed |
|
If we're messing with that add vis flyout, for the same reason I mentioned over here, we should consider using the EuiListGroup instead of the table to display the results. It does mean doing more manual hook up with the search and pagination, but it's both a better DOM element and a better click area. |
|
@cchaos In #27985 we are thinking about to get rid of the tabs and use a unified list of saved objects instead. Would it make sense to move this requirement over to #27985 since we are touching the component there anyway? Edit: The alternative would be to treat it as a separate issue @timroes created ( #30532 ) and do it ASAP for 7.0 |
💔 Build Failed |
|
Jenkins, test this. Infra down |
💚 Build Succeeded |
💚 Build Succeeded |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 12, 2019
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 12, 2019
flash1293
added a commit
that referenced
this pull request
Feb 12, 2019
flash1293
added a commit
that referenced
this pull request
Feb 12, 2019
7 tasks
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Apr 15, 2019
flash1293
added a commit
that referenced
this pull request
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #30067 (has to be merged first).
Fixes #30356
This PR switches from a small flyout for the add panel to a medium one. To better use the space of the flyout, 15 instead of 10 items per page are shown as default (they fit on a 13inch non-retina screen).
The default items per page are configurable via
initialPageSizeto make SavedObjectFinder usable in other environments where space is small.FYI @maryia-lapata
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately