[ML] Remove unneccessary indexPatterns call causing Anomaly Explorer to fail #30494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
non-issue
|
Pinging @elastic/ml-ui |
walterra
requested review from
alvarezmelissa87,
peteharverson and
jgowdyelastic
42 tasks
💚 Build Succeeded |
jgowdyelastic
approved these changes
Feb 8, 2019
| @@ -75,7 +74,6 @@ module.controller('MlExplorerController', function ( | |||
| // $scope should only contain what's actually still necessary for the angular part. | |||
| // For the moment that's the job selector and the (hidden) filter bar. | |||
| $scope.jobs = []; | |||
| $scope.indexPatterns = $route.current ? $route.current.locals.indexPatterns.map(getFromSavedObject) : []; | |||
There was a problem hiding this comment.
is indexPatterns: loadIndexPatterns, needed in the uiRoutes resolve object still?
There was a problem hiding this comment.
i think it is, as getIndexPatterns is used later on. so ignore this :)
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Feb 8, 2019
This was missed during the recent migrations to React of Anomaly Explorer in elastic#28750. It removes the now unnecessary `$scope.indexPatterns`.
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Feb 8, 2019
This was missed during the recent migrations to React of Anomaly Explorer in elastic#28750. It removes the now unnecessary `$scope.indexPatterns`.
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Feb 8, 2019
This was missed during the recent migrations to React of Anomaly Explorer in elastic#28750. It removes the now unnecessary `$scope.indexPatterns`.
lukeelmers
pushed a commit
to lukeelmers/kibana
that referenced
this pull request
Feb 8, 2019
This was missed during the recent migrations to React of Anomaly Explorer in elastic#28750. It removes the now unnecessary `$scope.indexPatterns`.
|
👍 |
peteharverson
pushed a commit
that referenced
this pull request
Feb 12, 2019
💚 Build Succeeded |
peteharverson
changed the title
peteharverson
pushed a commit
that referenced
this pull request
Feb 13, 2019
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This was missed during the recent migrations to React of Anomaly Explorer in #28750. It removes the now unnecessary
$scope.indexPatterns.Also fixes an issues where the call to
getFromSavedObjectto obtain the list of index patterns could cause the Anomaly Explorer to fail to render properly on opening with a syntax error reported when trying to parse the JSON:Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriatelyPart of #18553.