[ML] Fixing the unmounting jobs list react component on page change #29980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
bug
jgowdyelastic
requested review from
walterra,
alvarezmelissa87 and
peteharverson
|
Pinging @elastic/ml-ui |
💔 Build Failed |
|
retest |
jgowdyelastic
force-pushed
the
destroying-job-list-react-component-on-page-change
branch
from
9d495f9 to
92c566c
Compare
💚 Build Succeeded |
jgowdyelastic
force-pushed
the
destroying-job-list-react-component-on-page-change
branch
from
92c566c to
08fff36
Compare
💚 Build Succeeded |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Feb 5, 2019
jgowdyelastic
added a commit
that referenced
this pull request
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When navigating away from the jobs management page, the jobs summary poll continues to run. This caused by the main react jobs list component not being unmounted when the page changes.
It was introduced in this PR #20823 and is a side effect of no longer using
reactDirectiveto mount the react component in an angular directive.