fixes vislib legend filters

[ppisljar]

Summary

Resolves #28176
Resolves #29593

Release Note:
legend filtering for area/bar/line charts is working again

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• This was checked for cross-browser compatibility, including a check against IE11
• [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• [ ] Documentation was added for features that require explanation or tutorials
• [ ] Unit or functional tests were updated or added to match the most common scenarios
• [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

• [ ] This was checked for breaking API changes and was labeled appropriately
• This includes a feature addition or change that requires a release note and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app

[timroes]

This should get a couple of functional tests to prevent further regressions.

[ppisljar]

yeah, but in a separate PR, as we want those tests on master as well.

[timroes]

Indeed, but could you perhaps make sure that test PR is first merged, and this PR here is rebased so we can make sure it's working with the tests.

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[timroes]

Jenkins, test this - tested locally seems to work obviously I tested the wrong PR locally ..

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[timroes]

Removed the code for fixing #29593, since that also needs to go to master, and this is just a fix for 6.x. So that issue will need to go into a separate PR.

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[JacobBrandt]

@timroes I applied this change and noticed that the legend filter options always show up now.

This doesn't make sense in this case and applying this filter just picks the first thing drawn from the x-axis.

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[ppisljar]

retest

[JacobBrandt]

Tested latest changes and it's still not right. Still showing legend filter for Count which doesn't make sense. Also other bucket doesn't work right. Filtering on other doesn't negate all the other terms in the legend it only negates one.

Also the filters don't even show up for multiple split series.

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[flash1293]

@JacobBrandt

Tested latest changes and it's still not right. Still showing legend filter for Count which doesn't make sense. Also other bucket doesn't work right. Filtering on other doesn't negate all the other terms in the legend it only negates one.

These two work correctly for me (vertical bar chart):

@ppisljar

Also the filters don't even show up for multiple split series.

I can reproduce this one - two "Split Series" aggs don't show the filter anymore.

[markov00]

I've tested and found the following :

• ✅filter buttons are hidden on a single series aggregation

• ✅filter buttons are visible after a splitted series configuration (also without an x axis configured)

• ✅clicking + filter button on other will cause adding a filter that will shows the other buckets (NOT the non-other)

• ✅clicking - filter button on other will cause adding a filter that will shows only non-other buckets (limited to the size of the aggregation bucket)

• ⛔️when using multiple split series no filter buttons appear

[ppisljar]

thanks a lot to everyone for testing this one!

[ppisljar]

@JacobBrandt, thanks a lot for your help, i really appreciate it! Would you mind checking again the other bucket issue and filter buttons on count ? Does it only happen with some specific configuration or was it really general ?

[markov00]

Tested also on multiple split series and now it works.

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[JacobBrandt]

@ppisljar I must have been looking at that Count issue wrong. I don't see that happening. Split series now shows the filters again. I still see the other bucket filtering issue I was talking about as well as the split series filtering issue I already mentioned earlier. Not sure if you want to fix these in this ticket but just wanting to let you know.

Here is other bucket legend filtering picking the first in it's series. This one is odd because other means different things in each series so I'm not sure what it should filter on. I was thinking perhaps in this case it should filter out everything visible in the legend. This would make it behave logically as far as the legend display is concerned. Right now it's just whatever the first other in the series is which is not easy to discern which one that is or that it's going to do that.

EDIT: The more I look at it feels like other shouldn't be by itself unless it's not filterable. It highlights all others but then you can't filter on that highlighted group because some other terms are not other terms in the other series. Maybe in this case It should behave more like the split series and have "Kibana - Other", "Logstash Airways - Other", etc. With an additional non filterable legend of Other. The filtering with "Kibana - Other" would request to do both (like split series should do) and in the filter bar they can choose which ones to apply.

Here is the split series filtering picking the first in it's series. This one should filter on both values in the legend but picks one of the terms which again is not easy for the user to understand which one it will do.

Hope that helps.

[ppisljar]

thanks a lot for testing this @JacobBrandt

i created two issues: #31071 #31072

they are also present on master, so i will work on them separately, also they are not regressions as seems those behaved like that since initial implementation.

[bhavyarm]

On BC1 of 6.6.1 - this commit is missing.

[bhavyarm]

Please note the backport of this won't make 6.6.1. I have removed the 6.6.1 label. Thanks!

[dougburks]

I see the v6.6.2 label, but I don't see this issue listed in the 6.6.2 Release Notes:
https://www.elastic.co/guide/en/kibana/6.6/release-notes-6.6.2.html

Did the fix actually make it into the 6.6.2 release?

[timroes]

@dougburks that should have been in the 6.6.2. @gchaps do you have an idea why this PR is missing from the release notes? It looks like it should be labelled correctly?

Update: maybe it was the missing feature label. Could you please still add this to the release notes.

[dougburks]

Hi @timroes and thanks for the quick response!

If this is in 6.6.2, then may I ask for some clarification? I was tracking a change in Kibana behavior that started in 6.6.0 that I thought was #28176 and to be fixed by this PR. That change in behavior still exists in 6.6.2.

Here's an example:

• In previous versions of Kibana (up to 6.5.4), when I hover over a value in the legend, I can then click anywhere in the dark grey area to then show the magnifiers (meaning I don't have to click directly on the 7:
  

• Starting in 6.6.0 (and including 6.6.2), I now have to click directly on the number 7 itself (otherwise the magnifiers never show):
  

So if this PR is indeed in 6.6.2, is the behavior I'm seeing intended, or do I need to open another issue?

[gchaps]

@timroes This issue is now included in the 6.6.2 Release Notes.