Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.6] [es] when specifying path with vars always use encodeURIComponent (#29210) #29237

Merged
merged 1 commit into from
Jan 24, 2019
Merged

[6.6] [es] when specifying path with vars always use encodeURIComponent (#29210) #29237

merged 1 commit into from
Jan 24, 2019

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jan 24, 2019

Backports the following commits to 6.6:

[es] when specifying path with vars always use encodeURIComponent (el…
b2c811b 
…astic#29210)

Fixes elastic#29194

In node 10, urls are validated to not include any multi-byte characters, which wouldn't be possible if we were always encoding variables injected into URLs but we missed a couple places.
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger merged commit bbbacb0 into elastic:6.6 Jan 24, 2019
@spalger spalger deleted the backport/6.6/pr-29210 branch January 24, 2019 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spalger @elasticmachine