Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixing job cloning when it has an unknown created_by value #29175

Merged
merged 1 commit into from
Jan 23, 2019
Merged

[ML] Fixing job cloning when it has an unknown created_by value #29175

merged 1 commit into from
Jan 23, 2019

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Jan 23, 2019 •
edited
Loading

If a job has an unknown created_by value, the cloning functionality on the Jobs Management page doesn't work.
This fix forces the Advanced job page to be used in this situation.

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience v7.0.0 :ml Feature:Anomaly Detection ML anomaly detection v6.7.0 labels Jan 23, 2019
@jgowdyelastic jgowdyelastic self-assigned this Jan 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

walterra
walterra approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jgowdyelastic
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jgowdyelastic jgowdyelastic merged commit adbe6bb into elastic:master Jan 23, 2019
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jan 23, 2019
@jgowdyelastic
[ML] Fixing job cloning when it has an unknown created_by value (elas…
4262b2e 
…tic#29175)
@jgowdyelastic jgowdyelastic mentioned this pull request Jan 23, 2019
Merged
alvarezmelissa87
alvarezmelissa87 reviewed Jan 24, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jgowdyelastic added a commit that referenced this pull request Jan 24, 2019
@jgowdyelastic
[ML] Fixing job cloning when it has an unknown created_by value (#29175…
6ecd02e 
…) (#29216)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 left review comments

@walterra walterra walterra approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml v6.7.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @elasticmachine @walterra @alvarezmelissa87 @peteharverson