Small improvements to add cluster page #29142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
cjcenizal
added
v7.0.0
Team:Kibana Management
|
Pinging @elastic/es-ui |
cjcenizal
approved these changes
Jan 23, 2019
| color="subdued" | ||
| content={seedNodeTooltip} | ||
| /> | ||
| </EuiFlexItem> |
There was a problem hiding this comment.
We can nest the X icon and "Not connected" text inside another flex group, to get the tooltip to center over the icon like this:
<EuiFlexGroup gutterSize="s" alignItems="center">
<EuiFlexItem grow={false}>
<EuiFlexGroup gutterSize="s" alignItems="center">
<EuiFlexItem grow={false}>
{icon}
</EuiFlexItem>
<EuiFlexItem>
<EuiText>
{message}
</EuiText>
</EuiFlexItem>
</EuiFlexGroup>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiIconTip
color="subdued"
content={seedNodeTooltip}
/>
</EuiFlexItem>
</EuiFlexGroup>There was a problem hiding this comment.
Here's an updated screenshot from local test
| @@ -54,6 +59,13 @@ export function ConnectionStatus({ isConnected }) { | |||
| {message} | |||
| </EuiText> | |||
| </EuiFlexItem> | |||
| <EuiFlexItem> | |||
| <EuiIconTip | |||
| type="iInCircle" | |||
There was a problem hiding this comment.
iInCircle is the default value for type, so we can remove this.
💚 Build Succeeded |
cjcenizal
pushed a commit
to cjcenizal/kibana
that referenced
this pull request
Jan 23, 2019
Improve text around what port should be entered, and add a tooltip that explains the "Not Connected" error message.
cjcenizal
added a commit
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #28514. Adds two clarifying points to the add cluster page:
Checklist
This was checked for cross-browser compatibility, including a check against IE11Documentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers