throw config error based on the joi validation error #29137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legrego
approved these changes
Jan 22, 2019
There was a problem hiding this comment.
LGTM pending green CI - Tested locally. If there isn't a rush, let's wait on merging until @azasypkin also has a chance to review.
💚 Build Succeeded |
azasypkin
approved these changes
Jan 23, 2019
| @@ -124,7 +124,10 @@ export class Config { | |||
| }); | |||
|
|
|||
| if (results.error) { | |||
| throw results.error; | |||
| const error = new Error(results.error.message); | |||
There was a problem hiding this comment.
note: I prefer your solution to something like delete results.error._object; or dealing with any.error(...) since:
- we don't rely on Joi internals
- we throw error that we control (and ideally we should do that everywhere)
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Jan 23, 2019
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Jan 23, 2019
kobelb
added
v6.7.0
non-issue
kobelb
added a commit
that referenced
this pull request
Jan 23, 2019
kobelb
added a commit
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.