Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show old elasticsearch url config in docker docs #28929

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

joshdover
Copy link
Contributor

Summary

The docker image for Kibana does not support the ELASTICSEARCH_HOSTS config key yet, so we're going to have the docs continue to show the old configuration until 6.6.1 when elastic/kibana-docker#121 is released.

Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @joshdover

Do you mind creating an issue so we can remember to revert it back for elasticsearch.hosts on 6.6.1 ?

@joshdover
Copy link
Contributor Author

@mistic I'll go ahead and put up a PR so I don't forget

@joshdover joshdover merged commit 1f08d3f into elastic:6.6 Jan 17, 2019
@joshdover joshdover deleted the 6.6-docker-docs branch January 17, 2019 16:26
joshdover added a commit that referenced this pull request Jan 17, 2019
@joshdover joshdover added Team:Docs v6.6.0 Team:Operations Team label for Operations Team labels Jan 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

joshdover added a commit that referenced this pull request Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Docs Team:Operations Team label for Operations Team v6.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants