Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENV for overriding ES snapshot version #28768

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

joshdover
Copy link
Contributor

Summary

Adds TEST_ES_SNAPSHOT_VERSION which can point to a specific snapshot of ES for running tests against. Using this to unblock the Kibana team while #28757 is finished.

Copy link
Contributor

@chrisdavies chrisdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming CI passes. We may want to log something if we aren't using the default behavior (e.g. if there is an environmental override)

Didn't pull it down to test it.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@joshdover joshdover merged commit 0ba1db2 into elastic:master Jan 15, 2019
@joshdover joshdover deleted the lock-es-snapshot branch January 15, 2019 17:27
@joshdover joshdover added the Team:Operations Team label for Operations Team label Jan 15, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Team:Operations Team label for Operations Team v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants