Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deletes dead code in TSVB table #28761

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Deletes dead code in TSVB table #28761

merged 1 commit into from
Jan 24, 2019

Conversation

sulemanof
Copy link
Contributor

Summary

Dead code deletion in kibana/src/legacy/core_plugins/metrics/server/lib/vis_data/table folder

For maintainers

@sulemanof sulemanof changed the title Deleted dead code in TSVB table Deletes dead code in TSVB table Jan 15, 2019
alexwizp
alexwizp approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Looks like we don't need this code now.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@sulemanof
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@alexwizp
Copy link
Contributor

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@sulemanof
Copy link
Contributor Author

retest

@sulemanof sulemanof force-pushed the metrics/table/dead-code branch from f1ae473 to 67d2a77 Compare January 22, 2019 07:59
@elasticmachine
Copy link
Contributor

💔 Build Failed

@sulemanof
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

timroes
timroes approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the repo to validate it's actual dead code, and can't find any usage of that code, so LGTM

@timroes timroes added Feature:TSVB TSVB (Time Series Visual Builder) v7.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.7.0 labels Jan 24, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes timroes added the chore label Jan 24, 2019
@sulemanof sulemanof merged commit 5b6ecbc into elastic:master Jan 24, 2019
@sulemanof sulemanof deleted the metrics/table/dead-code branch January 24, 2019 10:10
@sulemanof sulemanof mentioned this pull request Jan 24, 2019
Closed
sulemanof added a commit to sulemanof/kibana that referenced this pull request Jan 24, 2019
@sulemanof
Deleted dead code (elastic#28761)
fcd1d9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@timroes timroes timroes approved these changes

@markov00 markov00 Awaiting requested review from markov00

Assignees
No one assigned
Labels
chore Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.7.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sulemanof @elasticmachine @alexwizp @timroes