Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Removes unused ml-item-select directive #28669

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

peteharverson
Copy link
Contributor

Summary

Removes the unused ml-item-select component.

This component was a wrapper for ui-select, used for configuring jobs and groups in the old Calendar Settings page. Since this page has now been converted to EUI / React in #26741, this directive is no longer needed.

@peteharverson peteharverson added review non-issue Indicates to automation that a pull request should not appear in the release notes v7.0.0 :ml Feature:Anomaly Detection ML anomaly detection v6.7.0 labels Jan 14, 2019
@peteharverson peteharverson requested a review from a team as a code owner January 14, 2019 11:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@peteharverson peteharverson merged commit e1a6f75 into elastic:master Jan 14, 2019
@peteharverson peteharverson deleted the ml-remove-item-select branch January 14, 2019 12:17
peteharverson added a commit to peteharverson/kibana that referenced this pull request Jan 14, 2019
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes review v6.7.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants