7.x field changes #28543
Merged
7.x field changes #28543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Heartbeat 7.0 there are a number of field changes that have been made to support ECS and refine the schema in other ways. This PR seeks to accomodate those changes, the most significant of which is the switch to extensive use of the ECS `url` namespace. One part of that is removing the Host dropdown filter rather than updating it. This control has always been effectively broken due to its inability to scale to a large number of hosts. Updating it makes no sense when it should be removed.
andrewvc
added
bug
|
Pinging @elastic/uptime |
💚 Build Succeeded |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
justinkambic
requested changes
Jan 17, 2019
x-pack/plugins/uptime/public/components/queries/monitor_list/monitor_list.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/uptime/public/components/queries/monitor_list/monitor_list.tsx
Show resolved
Hide resolved
x-pack/plugins/uptime/public/components/queries/monitor_status_bar/monitor_status_bar.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/uptime/public/components/queries/monitor_status_bar/monitor_status_bar.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/uptime/public/components/queries/monitor_status_bar/monitor_status_bar.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/uptime/public/components/queries/monitor_status_bar/monitor_status_bar.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/uptime/public/components/queries/monitor_status_bar/monitor_status_bar.tsx
Outdated
Show resolved
Hide resolved
|
Also - I don't know if this was caused by the code here or if there's some other problem, there's no way to know until |
…onitor_list.tsx Co-Authored-By: andrewvc <[email protected]>
💚 Build Succeeded |
💔 Build Failed |
andrewvc
force-pushed
the
7.x-field-changes
branch
from
76283c3 to
fc2c9e4
Compare
💚 Build Succeeded |
justinkambic
approved these changes
Jan 18, 2019
| values={{ port }} | ||
| defaultMessage="Port: {port}" | ||
| id="xpack.uptime.monitorStatusBar.healthStatus.ipMessage" | ||
| // TODO: this should not be computed inline |
There was a problem hiding this comment.
We can probably remove this comment. Not worth breaking CI for though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[Uptime] Adapt UI to 7.x Heartbeat Field Changes. NOTE: The 7.0 Uptime UI Will not work with 6.x Heartbeat data!
In Heartbeat 7.0 there are a number of field changes that have been made to support ECS and refine the schema in other ways. This PR seeks to accomodate those changes, the most significant of which is the switch to extensive use of the ECS
urlnamespace.One part of that is removing the Host dropdown filter rather than updating it. This control has always been effectively broken due to its inability to scale to a large number of hosts. Updating it makes no sense when it should be removed.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers