[ML] Converts Settings page to react #27144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
review
enhancement
alvarezmelissa87
requested review from
walterra,
peteharverson and
jgowdyelastic
|
Pinging @elastic/ml-ui |
💔 Build Failed |
88 tasks
|
retest |
💔 Build Failed |
peteharverson
approved these changes
Dec 14, 2018
alvarezmelissa87
force-pushed
the
ml-settings-page-react
branch
from
6fa50a3 to
1a92ef9
Compare
|
Updated with calendar permission check and updated tests. |
💔 Build Failed |
💚 Build Succeeded |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Dec 14, 2018
* Replace settings page with react directive * Adds test for Settings component * add calendar permission check * Update settings test * Remove outdated angular settings tests
alvarezmelissa87
added a commit
that referenced
this pull request
Dec 14, 2018
* [ML] Converts Settings page to react (#27144) * Replace settings page with react directive * Adds test for Settings component * add calendar permission check * Update settings test * Remove outdated angular settings tests * Remove k7 breadcrumbs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converts Settings page to Eui/React.
Migration to React issue: #18374
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorialsFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately