Optimize with thread loader and terser #27014

mistic · 2018-12-12T04:43:33Z

This PR is the result of revisiting an idea explored on #20749 with HappyPack (at that time the results were not good) in the very start of the DLL work experiments and also tried by @jbudz on #21994.

However this changes implements and explores things that we didn't tried before and that are giving us a lot of benefits.

Changes:

Add thread-loader to the basic optimizer both for babel-loader and ts-loader and also adding it to the babel-loader into the dll compiler
Add cache-loader for the babel-loader into the dll compiler
Create an unique thread-loader pool warming it up into the base optimizer constructor and sharing it also with the dll compiler
Replace the uglifyJsPlugin with terser-webpack-plugin as the later is the one used and supported right now by webpack since version 4.26.0.
Remove compress from terser-webpack-plugin into the base_optimizer. We have already done this in the past but were only keeping it due to the dead-code the removal check in React DevTools. So we can keep doing it, but only for the DynamicDllCompiler.

Results:

The results are from a machine with processing power for 8 threads however I guess it should be closer for machines with a processing power of 2 or more threads.

~ -45% time when optimizing in dev (or running from source)
~ -55% time running the optimizer from the distributable
~ + 0.3 - 1s time running the optimizer in dev when starting the server and we don't have any change since the last optimization. This is happening due to the overhead of spinning up the thread-loader worker pool (even warming up them). However in the subsequent rebuilds during the watch no time increase was detected.

Overall I just felt like the benefits are awesome!

…mize-with-thread-loader

…dll compiler.

…ll compiler.

…webpack plugin.

…er config.

…orker.

elasticmachine · 2018-12-12T04:43:35Z

Pinging @elastic/kibana-operations

elasticmachine · 2018-12-12T05:26:31Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

src/optimize/base_optimizer.js

…d also for the optimizer workers.

mistic · 2018-12-12T20:16:18Z

@jbudz @spalger I've updated the workerNodeArgs to contain the exact same arguments set on NODE_OPTIONS. I believe this way it will be more accurate and generic for any other NODE_OPTIONS that the users are applying to the main process already.

src/optimize/base_optimizer.js

elasticmachine · 2018-12-15T00:03:26Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

src/optimize/base_optimizer.js

spalger

LGTM, seems to work great, but I do think we should apply a max to the process count.

…ead-loader.

elasticmachine · 2018-12-15T03:53:57Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

tylersmalley · 2018-12-17T19:28:34Z

This is great, and I am very much looking forward to this change. However, before we merge we need to understand the total memory overhead of an optimize process in production. While we don't provide memory requirements, there are a lot of users with 2GB instances which expect Kibana to optimize within. Understanding what the changes here does to effect those will help us understand how we go forward including if we need to further reduce the max threads due to per-thread overhead.

…use the same calculated number of cpus to use on parallel tasks on thread loader pool config for terser parallel. refact(NA): lower down the poolTimeout on non dev mode. refact(NA): change devOnlyModules to nonDistributableOnlyModules on warmupThreadLoader config.

mistic · 2018-12-18T05:43:11Z

@tylersmalley I just ran some tests over 2 digital ocean droplets one of them without the thread-loader worker present on this PR and another one having this work. Both instances were also merged with the branch containing the work for this PR #27259 in order to be able to run and create production bundles from source.

Dropplets Hardware: 8GB/4vCPUs/60GB
Dropplets OS: CentOS 7.5 x64
Default Heap for Node 10 For The Hardware: 1526 MB
Cmd used to measure memory (Field = Mem: used): free -lmw -s 1

Note: (The following memory stats represents the max memory value used by the Droplet running the referenced command. Both instances only had the OS, the free command and the kibana running.)

`node scripts/kibana --env.name=production` (running from source with production bundles)

Non-Threaded Max Memory: 2724 MB
Non-Threaded Optimization Time: 231.06 seconds

Threaded Max Memory: 2751 MB
Threaded Optimization Time: 98.44 seconds

`./bin/kibana` (running from distributable)

Non-Threaded Max Memory: 2342 MB
Non-Threaded Optimization Time: 110.28 seconds

Threaded Max Memory: 1617 MB
Threaded Optimization Time: 34.18 seconds

I think from this date we can conclude this PR will improve both the optimization time and the memory footprint over the current master a LOT instead of making it worst 🎉 😄

elasticmachine · 2018-12-18T06:11:45Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

tylersmalley · 2018-12-18T07:34:27Z

This is very exciting @mistic, and thanks for benchmarking - I also did a quick test on a 2GB VM an see ~200MB less memory overhead when optimizing (down from 1.2GB).

🎉

spalger · 2018-12-18T12:54:48Z

Woah, I'm kinda shocked by that result. More processes takes up less memory... wouldn't have guessed!

tylersmalley · 2018-12-18T17:06:59Z

I wonder if the memory improvement came from improvements done in Terser - UglifyJS was historically bad with memory management.

mistic · 2018-12-18T17:16:22Z

Yeah I agree with you @tylersmalley and just remember that Terser is also enabled with the parallel option which means that an improvement on the minimizer itself will be multiplied by the number of workers too.

elasticmachine · 2018-12-18T17:50:26Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* multi thread expensive loaders * revert styles * feat(NA): added thread-loader and cache-loader to base optimizer and dll compiler. * feat(NA): added cache-loader and thread-loader to the optimizer and dll compiler. * feat(NA): use new terser plugin instead of old unmaintained uglifyjs webpack plugin. * refact(NA): remove unused configs from base optimizer and dll compiler. * fix(NA): available cpu calculated number. * docs(NA): fix comment about what we are doing in prod on base_optimizer config. * docs(NA): explain why we are setting memory into each thread loader worker. * fix(NA): add dev only loaders to the thread-loader warmup config. * refact(NA): change name from babelCacheDir to babelLoaderCacheDir. * fix(NA): logic for calculating available cpus. * feat(NA): pass NODE_OPTIONS along for the optimizer forked process and also for the optimizer workers. * feat(NA): remove terser webpack plugin compression from base_optimizer and only run it on dll compiler. * chore(NA): update function to calculate available cpus for works. * fix(NA): apply upperbound to the number of workers we can have on thread-loader. * fix(NA): decrease the max number of thread pool workers. refact(NA): use the same calculated number of cpus to use on parallel tasks on thread loader pool config for terser parallel. refact(NA): lower down the poolTimeout on non dev mode. refact(NA): change devOnlyModules to nonDistributableOnlyModules on warmupThreadLoader config. * chore(NA): update yarn lock deps after merging with master.

mistic · 2018-12-18T20:06:58Z

6.x: d53a9a2

jbudz and others added 13 commits August 15, 2018 08:05

multi thread expensive loaders

94222cd

revert styles

1c28ccc

Merge remote-tracking branch 'jbudz/optimize/thread-loader' into opti…

4d09300

…mize-with-thread-loader

feat(NA): added thread-loader and cache-loader to base optimizer and …

f7a54e6

…dll compiler.

feat(NA): added cache-loader and thread-loader to the optimizer and d…

f29254d

…ll compiler.

feat(NA): use new terser plugin instead of old unmaintained uglifyjs …

fac6d67

…webpack plugin.

refact(NA): remove unused configs from base optimizer and dll compiler.

c9bc82d

fix(NA): available cpu calculated number.

d3402fc

docs(NA): fix comment about what we are doing in prod on base_optimiz…

5a2eca4

…er config.

docs(NA): explain why we are setting memory into each thread loader w…

71895a5

…orker.

fix(NA): add dev only loaders to the thread-loader warmup config.

18b6608

refact(NA): change name from babelCacheDir to babelLoaderCacheDir.

5642d3e

fix(NA): logic for calculating available cpus.

e3a14b9

mistic added review Team:Operations Team label for Operations Team v7.0.0 v6.6.0 labels Dec 12, 2018

mistic self-assigned this Dec 12, 2018

mistic requested review from spalger and jbudz December 12, 2018 04:43

Merge branch 'master' into optimize-with-thread-loader

022a4e1

jbudz reviewed Dec 12, 2018

View reviewed changes

src/optimize/base_optimizer.js Outdated Show resolved Hide resolved

jbudz approved these changes Dec 12, 2018

View reviewed changes

feat(NA): pass NODE_OPTIONS along for the optimizer forked process an…

74762f8

…d also for the optimizer workers.

jbudz mentioned this pull request Dec 12, 2018

[poc/optimizer] performance #27073

Closed

elastic deleted a comment from elasticmachine Dec 12, 2018

This comment has been minimized.

Sign in to view

Merge branch 'master' into optimize-with-thread-loader

962dc0e

spalger reviewed Dec 14, 2018

View reviewed changes

src/optimize/base_optimizer.js Outdated Show resolved Hide resolved

src/optimize/base_optimizer.js Show resolved Hide resolved

mistic added 2 commits December 14, 2018 23:25

Merge branch 'master' into optimize-with-thread-loader

a6f724b

chore(NA): update function to calculate available cpus for works.

928b45d

spalger reviewed Dec 15, 2018

View reviewed changes

src/optimize/base_optimizer.js Outdated Show resolved Hide resolved

spalger approved these changes Dec 15, 2018

View reviewed changes

fix(NA): apply upperbound to the number of workers we can have on thr…

05b525b

…ead-loader.

mistic added 2 commits December 18, 2018 05:30

Merge branch 'master' into optimize-with-thread-loader

97e9b8e

tylersmalley approved these changes Dec 18, 2018

View reviewed changes

mistic added 2 commits December 18, 2018 16:42

Merge branch 'master' into optimize-with-thread-loader

ef2417c

chore(NA): update yarn lock deps after merging with master.

1e8538f

mistic force-pushed the optimize-with-thread-loader branch from 3025f1d to 1e8538f Compare December 18, 2018 16:46

chore(NA): merge and solve conflicts with master.

495cc18

This comment has been minimized.

Sign in to view

mistic merged commit efdf63d into elastic:master Dec 18, 2018

mistic mentioned this pull request Dec 18, 2018

[6.x] Optimize with thread loader and terser (#27014) #27426

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimize with thread loader and terser #27014

Optimize with thread loader and terser #27014

mistic commented Dec 12, 2018 •

edited

Loading

elasticmachine commented Dec 12, 2018

elasticmachine commented Dec 12, 2018

mistic commented Dec 12, 2018 •

edited

Loading

This comment has been minimized.

elasticmachine commented Dec 15, 2018

spalger left a comment

elasticmachine commented Dec 15, 2018

tylersmalley commented Dec 17, 2018

mistic commented Dec 18, 2018 •

edited

Loading

elasticmachine commented Dec 18, 2018

tylersmalley commented Dec 18, 2018

spalger commented Dec 18, 2018

tylersmalley commented Dec 18, 2018 •

edited

Loading

mistic commented Dec 18, 2018

This comment has been minimized.

elasticmachine commented Dec 18, 2018

mistic commented Dec 18, 2018

Optimize with thread loader and terser #27014

Optimize with thread loader and terser #27014

Conversation

mistic commented Dec 12, 2018 • edited Loading

elasticmachine commented Dec 12, 2018

elasticmachine commented Dec 12, 2018

💚 Build Succeeded

mistic commented Dec 12, 2018 • edited Loading

This comment has been minimized.

elasticmachine commented Dec 15, 2018

💚 Build Succeeded

spalger left a comment

Choose a reason for hiding this comment

elasticmachine commented Dec 15, 2018

💚 Build Succeeded

tylersmalley commented Dec 17, 2018

mistic commented Dec 18, 2018 • edited Loading

node scripts/kibana --env.name=production (running from source with production bundles)

./bin/kibana (running from distributable)

elasticmachine commented Dec 18, 2018

💚 Build Succeeded

tylersmalley commented Dec 18, 2018

spalger commented Dec 18, 2018

tylersmalley commented Dec 18, 2018 • edited Loading

mistic commented Dec 18, 2018

This comment has been minimized.

elasticmachine commented Dec 18, 2018

💚 Build Succeeded

mistic commented Dec 18, 2018

mistic commented Dec 12, 2018 •

edited

Loading

mistic commented Dec 12, 2018 •

edited

Loading

mistic commented Dec 18, 2018 •

edited

Loading

`node scripts/kibana --env.name=production` (running from source with production bundles)

`./bin/kibana` (running from distributable)

tylersmalley commented Dec 18, 2018 •

edited

Loading