[ML] Add rest_total_hit_as_int where total hits is required #26421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
non-issue
peteharverson
requested review from
walterra,
timroes,
alvarezmelissa87 and
jgowdyelastic
|
Pinging @elastic/ml-ui |
💔 Build Failed |
|
Jenkins, test this - ES master should accept the flag now |
💔 Build Failed |
timroes
approved these changes
Nov 30, 2018
|
Jenkins, test this - change should now be on master snapshot |
💔 Build Failed |
peteharverson
force-pushed
the
ml-es-total-hits
branch
from
c3be1e1 to
128de83
Compare
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Dec 4, 2018
peteharverson
added a commit
that referenced
this pull request
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements step 1 of #26356 for the ML UI, adding
rest_total_hits_as_int=trueto all requests to Elasticsearch where we need to gethits.total.After 7.0 has been released, steps 2 and 3 of #26356 should be addressed in a follow-up PR. Most of the ML uses of
hits.totalcan probably either be switched to use the estimated hits count, or be removed altogether.Checklist
N/A