removing indexPattern from vega/tsvb/timelion request handler #26007
Conversation
ppisljar
added
review
v7.0.0
Team:Visualizations
|
Pinging @elastic/kibana-app |
| @@ -41,7 +41,7 @@ const TimelionRequestHandlerProvider = function (Private, Notifier, $http) { | |||
| sheet: [expression], | |||
| extended: { | |||
| es: { | |||
| filter: buildEsQuery(aggs.indexPattern, [query], filters) | |||
| filter: buildEsQuery(undefined, [query], filters) | |||
There was a problem hiding this comment.
the index pattern is actually defined in the expression (and there could be multiple of them) ...
so the aggs.indexPattern was not set anyway. In the future we would need to execute this on the server side with appropriate indexPatterns in order to support KQL fully
💔 Build Failed |
|
retest |
There was a problem hiding this comment.
This PR #26006 will remove the use of buildEsQuery from TSVB moving it serverside.
I think for Vega and Timelion we need to fix also buildEsQuery to accept undefined index pattern and ignore Kuery query, if not this will throw an error on building the ES request using AST
After a chat with Peter, everything is fine as this PR will not introduce any fix at all in the buildEsQuery, everything is exactly the same as in the current master version.
💚 Build Succeeded |
Summary
removes unused aggs.indexPattern from vega, tsvb and timelion request handler
preparation for #25996
QA: no functional changes
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately