[ML] Ensures jobs from saved searches are cloned in advanced wizard #26002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
release_note:fix
v7.0.0
:ml
Feature:Anomaly Detection
peteharverson
requested review from
walterra,
alvarezmelissa87 and
jgowdyelastic
|
Pinging @elastic/ml-ui |
x-pack/plugins/ml/public/jobs/new_job/simple/multi_metric/create_job/create_job_controller.js
Outdated
Show resolved
Hide resolved
💔 Build Failed |
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Nov 21, 2018
…lastic#26002) * [ML] Ensures jobs from saved searches are cloned in advanced wizard * [ML] Use useSavedSearch property for setting job created_by
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Nov 23, 2018
…lastic#26002) * [ML] Ensures jobs from saved searches are cloned in advanced wizard * [ML] Use useSavedSearch property for setting job created_by
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
custom_settingscreated_byproperty is now no longer added for a job created in the Single Metric, Multi Metric or Population wizards if created from a saved search.The wizards currently only accept an index pattern ID or a saved search ID, and not a query DSL, which meant that previously when cloning a job created in a wizard from a saved search, the datafeed query would be silently dropped.
Removing the
custom_settingscreated_byproperty means that such jobs are now cloned in the Advanced Wizard, which does preserve the datafeed query set on the original job from the saved search.Checklist
For maintainers
[ ] This was checked for breaking API changes and was labeled appropriatelyFixes #25932