[ML] Fix cleanup of mlAnomaliesTableService listeners in Time Series Viewer. #25967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
walterra
requested review from
alvarezmelissa87,
peteharverson and
jgowdyelastic
|
Pinging @elastic/ml-ui |
3 tasks
💔 Build Failed |
peteharverson
approved these changes
Nov 21, 2018
x-pack/plugins/ml/public/components/chart_tooltip/chart_tooltip_service.js
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Nov 21, 2018
…Viewer. (elastic#25967) - A missing call to componentWillUnmount() in the Single Series Viewer didn't properly clean up the listeners for mlAnomaliesTableService so when switching to the Anomaly Explorer the page would crash if the user hovered the Anomaly Table. - This fixes it by calling ReactDOM.unmountComponentAtNode(element[0]); in element.on('$destroy', () => { ... }) to trigger the cleanup. - Additionally, as a safety measure, mlChartTooltipService.show() now silently fails if target is undefined.
💚 Build Succeeded |
walterra
added a commit
that referenced
this pull request
Nov 21, 2018
…Viewer. (#25967) (#26001) - A missing call to componentWillUnmount() in the Single Series Viewer didn't properly clean up the listeners for mlAnomaliesTableService so when switching to the Anomaly Explorer the page would crash if the user hovered the Anomaly Table. - This fixes it by calling ReactDOM.unmountComponentAtNode(element[0]); in element.on('$destroy', () => { ... }) to trigger the cleanup. - Additionally, as a safety measure, mlChartTooltipService.show() now silently fails if target is undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A missing call to
componentWillUnmount()in the Single Series Viewer didn't properly clean up the listeners formlAnomaliesTableServiceso when switching to the Anomaly Explorer the page would crash if the user hovered the Anomaly Table.This fixes it by calling
ReactDOM.unmountComponentAtNode(element[0]);inelement.on('$destroy', () => { ... })to trigger the cleanup.Additionally, as a safety measure,
mlChartTooltipService.show()now silently fails iftargetisundefined.Checklist
This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriatelyPart of #25791.