[ML] Ensure Anomaly Explorer and Single View do not hang by fixing TypeError: finally is not a function #25961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
requested review from
walterra,
peteharverson and
jgowdyelastic
|
Pinging @elastic/ml-ui |
alvarezmelissa87
changed the title
💚 Build Succeeded |
| @@ -264,7 +264,8 @@ module.controller('MlExplorerController', function ( | |||
|
|
|||
| // Populate the map of jobs / detectors / field formatters for the selected IDs. | |||
| mlFieldFormatService.populateFormats(selectedIds, getIndexPatterns()) | |||
| .finally(() => { | |||
| .catch((err) => { console.log('Error setting selected jobs:', err); }) | |||
There was a problem hiding this comment.
Can you change this error message to say Error populating field formats. The jobs will be selected ok, it's just actual and typical values will be formatted using the default numeric formatting rather than e.g. as bytes, if a formatter has been applied for that field.
| .finally(() => { | ||
| // Load the data - if the FieldFormats failed to populate | ||
| // the default formatting will be used for metric values. | ||
| .catch((err) => { console.log('Error loading job:', err); }) |
There was a problem hiding this comment.
As above, this error should say Error populating field formats
💔 Build Failed |
peteharverson
added
the
non-issue
|
retest |
💚 Build Succeeded |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Nov 21, 2018
…peError: finally is not a function (elastic#25961) * Replace finally with catch/then to fix typeError * update error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces calls to
finallywhich is not supported (as we move away from Angular) withcatchandthento fixTypeError: finally not a functionerror and preventLoading...hang due to this error..finallycall inexplorer_controller.js.finallycall intimeseriesexplorer_controller.jsChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately