Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixes font size regressions following less to sass conversion #25945

Merged
merged 1 commit into from
Nov 21, 2018
Merged

[ML] Fixes font size regressions following less to sass conversion #25945

merged 1 commit into from
Nov 21, 2018

Conversation

peteharverson
Copy link
Contributor

Fixes various font sizes following the less to sass conversion in #25574. euiSizeXS (4px) was being used where it should have been euiFontSizeXS (12px).

  • Recognizer job wizard Kibana saved object 'already exists' warnings
  • Anomaly Explorer chart tick labels
  • Job Wizard event rate chart tick labels
  • Single Metric job wizard chart

Example before:
explorer_chart_font_size_before

after:
image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

@peteharverson peteharverson added review non-issue Indicates to automation that a pull request should not appear in the release notes v7.0.0 :ml Feature:Anomaly Detection ML anomaly detection Feature:ml-results legacy - do not use cosmetic v6.6.0 labels Nov 20, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

walterra
walterra approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

alvarezmelissa87
alvarezmelissa87 approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@peteharverson peteharverson merged commit 9ca8cff into elastic:master Nov 21, 2018
@peteharverson peteharverson deleted the ml-scss-font-sizes branch November 21, 2018 09:34
@peteharverson peteharverson mentioned this pull request Nov 21, 2018
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request Nov 21, 2018
@peteharverson
[ML] Fixes font size regressions following less to sass conversion (e…
328c291 
…lastic#25945)
peteharverson added a commit that referenced this pull request Nov 21, 2018
@peteharverson
[ML] Fixes font size regressions following less to sass conversion (#…
b353545 
…25945) (#25995)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra walterra approved these changes

Assignees
No one assigned
Labels
cosmetic Feature:Anomaly Detection ML anomaly detection Feature:ml-results legacy - do not use :ml non-issue Indicates to automation that a pull request should not appear in the release notes review v6.6.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peteharverson @elasticmachine @walterra @alvarezmelissa87