[babel-register] ignore built canvas plugins #25913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
review
Team:Operations
|
Pinging @elastic/kibana-operations |
💚 Build Succeeded |
jbudz
approved these changes
Nov 20, 2018
mistic
approved these changes
Nov 20, 2018
There was a problem hiding this comment.
LGTM! @spalger maybe @elastic/kibana-canvas could use a different extension, like .es6 for files they will need to be parsed by babel-register because they will be copied as-is. In case they do that we will be able to automatically ignore everything in the register.
…ore-built-canvas-plugin
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 20, 2018
spalger
pushed a commit
that referenced
this pull request
Nov 21, 2018
|
6.x/6.6: 8f84950 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an exclude regex to babel-register that excludes the built plugins from canvas, except for the items in the
functions/serverdirectory. This is the only directory that is copied as-is fromcanvas_plugin_src, and therefore is reliant on babel-register, but I'm not sure it's the only directory that will ever be reliant on babel-register so cc: @elastic/kibana-canvas