Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes APM home page to use route-based tabs #25891

Merged
merged 5 commits into from
Nov 21, 2018

Conversation

jasonrhodes
Copy link
Member

@jasonrhodes jasonrhodes commented Nov 19, 2018

Closes #23824

Summary

To make new routes for the /services and /traces tabs that are navigable via browser address, I used React Router's <Route> component nested inside the <Home> route. I moved this type of Tabbed Content out to a new component called HistoryTabs, which are now reusable anywhere else we'd like to use this pattern (with a prerequisite that all the top-level paths have to point to the single component where the history tabs live).

Also adds a test, and a redirect from / -> /services via the route config file.

To Do:

  • Figure out what to do with the query string when these routes change

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jasonrhodes jasonrhodes requested a review from ogupte November 20, 2018 17:24
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@@ -94,3 +114,18 @@ export const routes = [
legacyDecodeURIComponent(match.params.transactionName)
}
];
// {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented code

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jasonrhodes
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jasonrhodes jasonrhodes merged commit 453e1f1 into elastic:master Nov 21, 2018
jasonrhodes added a commit to jasonrhodes/kibana that referenced this pull request Nov 21, 2018
* Changed home page to use route based history tabs, abstracted history tabs to component with tests

* Spreads location on tab links to preserve query string etc

* Adds ts-ignore to 'fix' problem with TS not finding EuiTab and EuiTabs modules in EUI exports

* Fixes breadcrumbs and service redirect

* Removes commented code
@jasonrhodes jasonrhodes deleted the service-trace-routes branch November 21, 2018 16:51
jasonrhodes added a commit that referenced this pull request Nov 25, 2018
* Changed home page to use route based history tabs, abstracted history tabs to component with tests

* Spreads location on tab links to preserve query string etc

* Adds ts-ignore to 'fix' problem with TS not finding EuiTab and EuiTabs modules in EUI exports

* Fixes breadcrumbs and service redirect

* Removes commented code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants